momchil-velikov wrote:

```
    if (HasTile) {
      MIB.addReg(BaseReg + MI.getOperand(0).getImm(), RegState::Define);
      MIB.addReg(BaseReg + MI.getOperand(0).getImm());
      StartIdx = 1;
    } else
      MIB.addReg(BaseReg, RegState::Define).addReg(BaseReg);
  }
```

Needs extra braces around the `else` clause,  
https://llvm.org/docs/CodingStandards.html#don-t-use-braces-on-simple-single-statement-bodies-of-if-else-loop-statements

cf.

```
// Use braces for the `if` block to keep it uniform with the `else` block.
if (isa<FunctionDecl>(D)) {
  handleFunctionDecl(D);
} else {
  // In this `else` case, it is necessary that we explain the situation with
  // this surprisingly long comment, so it would be unclear without the braces
  // whether the following statement is in the scope of the `if`.
  handleOtherDecl(D);
}
```

https://github.com/llvm/llvm-project/pull/88710
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to