https://github.com/SLTozer commented:
I think the comment about `s/members/methods/` is still outstanding - I agree that methods is more descriptive than members. I'm +1 on having this be non-default; adding it to SCE tuning is also not necessary (or desired) for now, because this is more aggressive than our private option (we keep entries for member functions that are called), and we're still working out whether we can/should adopt this instead. Otherwise, existing comments aside, this looks good: the size reduction is considerable, and likely becoming necessary for some. https://github.com/llvm/llvm-project/pull/87018 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
