sbc100 wrote: > It is hard to fix the clang-format errors because the modified files > generally don't conform to the clang-format style anyway, so clang-format my > change currently affects hundreds of unrelated lines. > > ``` > aheejin@aheejin:~/llvm-project/libunwind$ git clang-format main > changed files: > libcxxabi/include/cxxabi.h > libcxxabi/src/cxa_exception.cpp > libcxxabi/src/cxa_personality.cpp > > aheejin@aheejin:~/llvm-project/libunwind$ git diff --stat > libcxxabi/include/cxxabi.h | 13 +- > libcxxabi/src/cxa_exception.cpp | 2 +- > libcxxabi/src/cxa_personality.cpp | 256 > ++++++++++++++++++---------------------- > 3 files changed, 123 insertions(+), 148 deletions(-) > ```
I think in these cases is fine to ignore the warnings to fit in with existing style. https://github.com/llvm/llvm-project/pull/92840 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
