================ @@ -1081,6 +1088,12 @@ static llvm::Triple::EnvironmentType getEnvironmentType(llvm::StringRef Environm .Case("hull", llvm::Triple::Hull) .Case("domain", llvm::Triple::Domain) .Case("compute", llvm::Triple::Compute) + .Case("raygeneration", llvm::Triple::RayGeneration) ---------------- damyanp wrote:
Are `llvm::Triple::RayGeneration` and `llvm::Triple::EnvironmentType::RayGeneration` referring to the same thing? If they are I think it'd be good to be consistent. I think `EnvironmentType` is the enum name so there's no need to repeat it in the other places it appears. https://github.com/llvm/llvm-project/pull/92704 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits