AaronBallman wrote:

Comments in the config file isn't a harmful thing, but I'm also worried about 
folks who never see the config file. e.g., they're working in Path.inc on 
something, see `HAVE_PWD_H` in the code, and just make assumptions from there.

So perhaps a two-pronged approach: a comment in config.h for the cases where we 
don't expect a graceful fallback, and a similar comment around the guarded 
#include in source for the folks who won't look in config.h?

https://github.com/llvm/llvm-project/pull/92677
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to