Author: martinboehme Date: 2024-06-04T17:08:20+02:00 New Revision: 492417278d986ddd8206b2b9bba626ce690ea244
URL: https://github.com/llvm/llvm-project/commit/492417278d986ddd8206b2b9bba626ce690ea244 DIFF: https://github.com/llvm/llvm-project/commit/492417278d986ddd8206b2b9bba626ce690ea244.diff LOG: [clang][dataflow] Propagate storage location of compound assignment operators. (#94332) To avoid generating unnecessary values, we don't create a new value but instead leave it to the specific analysis to do this if desired. Added: Modified: clang/lib/Analysis/FlowSensitive/Transfer.cpp clang/unittests/Analysis/FlowSensitive/TransferTest.cpp Removed: ################################################################################ diff --git a/clang/lib/Analysis/FlowSensitive/Transfer.cpp b/clang/lib/Analysis/FlowSensitive/Transfer.cpp index d161b231c0b6f..8109ac6a781e7 100644 --- a/clang/lib/Analysis/FlowSensitive/Transfer.cpp +++ b/clang/lib/Analysis/FlowSensitive/Transfer.cpp @@ -147,6 +147,13 @@ class TransferVisitor : public ConstStmtVisitor<TransferVisitor> { const Expr *RHS = S->getRHS(); assert(RHS != nullptr); + // Do compound assignments up-front, as there are so many of them and we + // don't want to list all of them in the switch statement below. + // To avoid generating unnecessary values, we don't create a new value but + // instead leave it to the specific analysis to do this if desired. + if (S->isCompoundAssignmentOp()) + propagateStorageLocation(*S->getLHS(), *S, Env); + switch (S->getOpcode()) { case BO_Assign: { auto *LHSLoc = Env.getStorageLocation(*LHS); diff --git a/clang/unittests/Analysis/FlowSensitive/TransferTest.cpp b/clang/unittests/Analysis/FlowSensitive/TransferTest.cpp index cdaee9b2c9288..f7e6b0c22e8db 100644 --- a/clang/unittests/Analysis/FlowSensitive/TransferTest.cpp +++ b/clang/unittests/Analysis/FlowSensitive/TransferTest.cpp @@ -3796,6 +3796,26 @@ TEST(TransferTest, Postincrement) { }); } +// We test just one of the compound assignment operators because we know the +// code for propagating the storage location is shared among all of them. +TEST(TransferTest, AddAssign) { + std::string Code = R"( + void target(int I) { + int &IRef = (I += 1); + // [[p]] + } + )"; + runDataflow( + Code, + [](const llvm::StringMap<DataflowAnalysisState<NoopLattice>> &Results, + ASTContext &ASTCtx) { + const Environment &Env = getEnvironmentAtAnnotation(Results, "p"); + + EXPECT_EQ(&getLocForDecl(ASTCtx, Env, "IRef"), + &getLocForDecl(ASTCtx, Env, "I")); + }); +} + TEST(TransferTest, CannotAnalyzeFunctionTemplate) { std::string Code = R"( template <typename T> _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
