pcc marked 3 inline comments as done.
pcc added inline comments.
================
Comment at: clang/include/clang/AST/VTableBuilder.h:255
+ operator ArrayRef<T>() const { return {data(), size()}; };
+ };
+
----------------
rjmccall wrote:
> Maybe this ought to be in LLVM as OwnedArrayRef? And the more minimal
> implementation approach would be to inherit from MutableArrayRef<T> and just
> add a destructor and a move constructor.
>
> The implicit conversion to ArrayRef is dangerous, but only in ways that
> ArrayRef is already dangerous.
Good suggestions -- sent out D27723.
https://reviews.llvm.org/D22296
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
