https://github.com/PiotrZSL created
https://github.com/llvm/llvm-project/pull/94524
Ignore implicit pointer conversions that are part of a cast expression
Closes #93959
>From bdff94eb18212005d059a5cbb8d649a356fdd301 Mon Sep 17 00:00:00 2001
From: Piotr Zegar <m...@piotrzegar.pl>
Date: Wed, 5 Jun 2024 19:19:38 +0000
Subject: [PATCH] [clang-tidy] Improve
bugprone-multi-level-implicit-pointer-conversion
Ignore implicit pointer conversions that are part of a cast expression
Closes #93959
---
.../MultiLevelImplicitPointerConversionCheck.cpp | 11 ++++++++++-
clang-tools-extra/docs/ReleaseNotes.rst | 4 ++++
.../multi-level-implicit-pointer-conversion.cpp | 12 ++++++++++++
3 files changed, 26 insertions(+), 1 deletion(-)
diff --git
a/clang-tools-extra/clang-tidy/bugprone/MultiLevelImplicitPointerConversionCheck.cpp
b/clang-tools-extra/clang-tidy/bugprone/MultiLevelImplicitPointerConversionCheck.cpp
index 4dd3cb57e6dd1..7a989b07119aa 100644
---
a/clang-tools-extra/clang-tidy/bugprone/MultiLevelImplicitPointerConversionCheck.cpp
+++
b/clang-tools-extra/clang-tidy/bugprone/MultiLevelImplicitPointerConversionCheck.cpp
@@ -48,12 +48,21 @@ AST_MATCHER(ImplicitCastExpr,
isMultiLevelPointerConversion) {
return SourcePtrLevel != TargetPtrLevel;
}
+AST_MATCHER(QualType, isPointerType) {
+ const QualType Type =
+ Node.getCanonicalType().getNonReferenceType().getUnqualifiedType();
+
+ return !Type.isNull() && Type->isPointerType();
+}
+
} // namespace
void MultiLevelImplicitPointerConversionCheck::registerMatchers(
MatchFinder *Finder) {
Finder->addMatcher(
- implicitCastExpr(hasCastKind(CK_BitCast),
isMultiLevelPointerConversion())
+ implicitCastExpr(hasCastKind(CK_BitCast),
isMultiLevelPointerConversion(),
+ unless(hasParent(explicitCastExpr(
+ hasDestinationType(isPointerType())))))
.bind("expr"),
this);
}
diff --git a/clang-tools-extra/docs/ReleaseNotes.rst
b/clang-tools-extra/docs/ReleaseNotes.rst
index 6947cf06f6e56..d1e0543a513a5 100644
--- a/clang-tools-extra/docs/ReleaseNotes.rst
+++ b/clang-tools-extra/docs/ReleaseNotes.rst
@@ -218,6 +218,10 @@ Changes in existing checks
check by ignoring ``__func__`` macro in lambda captures, initializers of
default parameters and nested function declarations.
+- Improved :doc:`bugprone-multi-level-implicit-pointer-conversion
+ <clang-tidy/checks/bugprone/multi-level-implicit-pointer-conversion>` check
+ by ignoring implicit pointer conversions that are part of a cast expression.
+
- Improved :doc:`bugprone-non-zero-enum-to-bool-conversion
<clang-tidy/checks/bugprone/non-zero-enum-to-bool-conversion>` check by
eliminating false positives resulting from direct usage of bitwise operators
diff --git
a/clang-tools-extra/test/clang-tidy/checkers/bugprone/multi-level-implicit-pointer-conversion.cpp
b/clang-tools-extra/test/clang-tidy/checkers/bugprone/multi-level-implicit-pointer-conversion.cpp
index 7a56242e4202d..6868f9e590908 100644
---
a/clang-tools-extra/test/clang-tidy/checkers/bugprone/multi-level-implicit-pointer-conversion.cpp
+++
b/clang-tools-extra/test/clang-tidy/checkers/bugprone/multi-level-implicit-pointer-conversion.cpp
@@ -63,3 +63,15 @@ void test()
takeSecondLevelVoidPtr(getSecondLevelVoidPtr());
}
+
+namespace PR93959 {
+ void free(void*);
+
+ void test() {
+ char **p = nullptr;
+ free(p);
+ // CHECK-MESSAGES: :[[@LINE-1]]:10: warning: multilevel pointer conversion
from 'char **' to 'void *', please use explicit cast
[bugprone-multi-level-implicit-pointer-conversion]
+ free((void *)p);
+ free(static_cast<void *>(p));
+ }
+}
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
