dcoughlin accepted this revision. dcoughlin added a comment. This revision is now accepted and ready to land.
The diagnostics look great to me and the macro logic seems reasonable. ================ Comment at: test/Analysis/diagnostics/macros.cpp:49 +} \ No newline at end of file ---------------- Missing newline? https://reviews.llvm.org/D27726 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits