beanz accepted this revision. beanz added a comment. LGTM other than a few style comments. Please clang-format before committing. Some of the formatting looks off (although that might just be my phone).
================ Comment at: lib/Support/PrettyStackTrace.cpp:152 + va_start(ap, format); + const int size_or_error = vsnprintf(nullptr, 0, format, ap); + va_end(ap); ---------------- Your variable names are very LLDB-esque. Please follow the LLVM style guide, which is CamelCase. Repository: rL LLVM https://reviews.llvm.org/D27683 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
