[clang] [clang] Don't use -Wno-nested-anon-types on GCC (PR #95029)

[via cfe-commits]

llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-clang

Author: Martin Storsjö (mstorsjo)

<details>
<summary>Changes</summary>

GCC usually doesn't warn about unrecognized -Wno-&lt;foo&gt; options, if no 
diagnostics are printed. However if some diagnostics are printed, it also 
mentions that there were unrecognized -Wno-&lt;foo&gt; options.

Before 4feae05c6abda364a9295aecfa600d7d4e7dfeb6, we checked for whether 
-Wnested-anon-types was supported, and added the -Wno-&lt;foo&gt; form if the 
positive form of the option was supported.

As of GCC 14, -Wnested-anon-types isn't supported, thus limit the use of the 
option to actual Clang (and still only while using the GCC compatible driver).

This avoids unnecessary mentions about unrecognized -Wno-&lt;foo&gt; options 
when building with GCC.

---
Full diff: https://github.com/llvm/llvm-project/pull/95029.diff


1 Files Affected:

- (modified) clang/CMakeLists.txt (+3-1) 


``````````diff
diff --git a/clang/CMakeLists.txt b/clang/CMakeLists.txt
index 2ac0bccb42f50..2b5269f2ce2e7 100644
--- a/clang/CMakeLists.txt
+++ b/clang/CMakeLists.txt
@@ -350,7 +350,9 @@ if (LLVM_COMPILER_IS_GCC_COMPATIBLE)
     set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -pedantic -Wno-long-long")
   endif ()
 
-  set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-nested-anon-types" )
+  if (CMAKE_CXX_COMPILER_ID MATCHES "Clang")
+    set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-nested-anon-types" )
+  endif ()
 endif ()
 
 # Determine HOST_LINK_VERSION on Darwin.

``````````

</details>


https://github.com/llvm/llvm-project/pull/95029
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits