llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT--> @llvm/pr-subscribers-clang-tidy Author: Congcong Cai (HerrCai0907) <details> <summary>Changes</summary> Fixes: #<!-- -->95596 Check will warn if the loop var type is not same as var init expr type --- Full diff: https://github.com/llvm/llvm-project/pull/95667.diff 3 Files Affected: - (modified) clang-tools-extra/clang-tidy/performance/InefficientVectorOperationCheck.cpp (+3-3) - (modified) clang-tools-extra/docs/ReleaseNotes.rst (+5) - (modified) clang-tools-extra/test/clang-tidy/checkers/performance/inefficient-vector-operation.cpp (+35) ``````````diff diff --git a/clang-tools-extra/clang-tidy/performance/InefficientVectorOperationCheck.cpp b/clang-tools-extra/clang-tidy/performance/InefficientVectorOperationCheck.cpp index 20aea5a79fe9a..dc6e0cf9c7d12 100644 --- a/clang-tools-extra/clang-tidy/performance/InefficientVectorOperationCheck.cpp +++ b/clang-tools-extra/clang-tidy/performance/InefficientVectorOperationCheck.cpp @@ -105,9 +105,9 @@ void InefficientVectorOperationCheck::addMatcher( onImplicitObjectArgument(declRefExpr(to(TargetVarDecl)))) .bind(AppendCallName); const auto AppendCall = expr(ignoringImplicit(AppendCallExpr)); - const auto LoopVarInit = - declStmt(hasSingleDecl(varDecl(hasInitializer(integerLiteral(equals(0)))) - .bind(LoopInitVarName))); + const auto LoopVarInit = declStmt(hasSingleDecl( + varDecl(hasInitializer(ignoringParenImpCasts(integerLiteral(equals(0))))) + .bind(LoopInitVarName))); const auto RefersToLoopVar = ignoringParenImpCasts( declRefExpr(to(varDecl(equalsBoundNode(LoopInitVarName))))); diff --git a/clang-tools-extra/docs/ReleaseNotes.rst b/clang-tools-extra/docs/ReleaseNotes.rst index 7092d0b6fdb02..3bdd735f7dcf7 100644 --- a/clang-tools-extra/docs/ReleaseNotes.rst +++ b/clang-tools-extra/docs/ReleaseNotes.rst @@ -387,6 +387,11 @@ Changes in existing checks - Improved :doc:`modernize-use-using <clang-tidy/checks/modernize/use-using>` check by adding support for detection of typedefs declared on function level. +- Improved :doc:`performance-inefficient-vector-operation + <clang-tidy/checks/performance/inefficient-vector-operation>` fixing false + negatives caused by different variable definition type and variable initial + value type in loop initialization expression. + - Improved :doc:`performance-move-const-arg <clang-tidy/checks/performance/move-const-arg>` check by ignoring ``std::move()`` calls when their target is used as an rvalue. diff --git a/clang-tools-extra/test/clang-tidy/checkers/performance/inefficient-vector-operation.cpp b/clang-tools-extra/test/clang-tidy/checkers/performance/inefficient-vector-operation.cpp index c28592f4d6368..50424920d72b7 100644 --- a/clang-tools-extra/test/clang-tidy/checkers/performance/inefficient-vector-operation.cpp +++ b/clang-tools-extra/test/clang-tidy/checkers/performance/inefficient-vector-operation.cpp @@ -387,3 +387,38 @@ void foo(const StructWithFieldContainer &Src) { B.push_back(Number); } } + +namespace gh95596 { + +void f(std::vector<int>& t) { + { + std::vector<int> gh95596_0; + // CHECK-FIXES: gh95596_0.reserve(10); + for (unsigned i = 0; i < 10; ++i) + gh95596_0.push_back(i); + // CHECK-MESSAGES: :[[@LINE-1]]:7: warning: 'push_back' is called inside a loop; consider pre-allocating the container capacity before the loop + } + { + std::vector<int> gh95596_1; + // CHECK-FIXES: gh95596_1.reserve(10); + for (int i = 0U; i < 10; ++i) + gh95596_1.push_back(i); + // CHECK-MESSAGES: :[[@LINE-1]]:7: warning: 'push_back' is called inside a loop; consider pre-allocating the container capacity before the loop + } + { + std::vector<int> gh95596_2; + // CHECK-FIXES: gh95596_2.reserve(10); + for (unsigned i = 0U; i < 10; ++i) + gh95596_2.push_back(i); + // CHECK-MESSAGES: :[[@LINE-1]]:7: warning: 'push_back' is called inside a loop; consider pre-allocating the container capacity before the loop + } + { + std::vector<int> gh95596_3; + // CHECK-FIXES: gh95596_3.reserve(10U); + for (int i = 0; i < 10U; ++i) + gh95596_3.push_back(i); + // CHECK-MESSAGES: :[[@LINE-1]]:7: warning: 'push_back' is called inside a loop; consider pre-allocating the container capacity before the loop + } +} + +} // namespace gh95596 \ No newline at end of file `````````` </details> https://github.com/llvm/llvm-project/pull/95667 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
