aaron.ballman added inline comments.

================
Comment at: clang-tidy/misc/SuspiciousEnumUsageCheck.cpp:31
+    "enum type seems like a bitmask (contains mostly "
+    "power-of-2 literals) but some literal(s) are not a power-of-2";
+
----------------
Please drop the `(s)` from the diagnostic. The phrase "but some literal are 
not" is incorrect. Alternatively, you could use the `%plural` diagnostic 
modifier (see `note_constexpr_baa_value_insufficient_alignment` in 
DiagnosticASTKinds.td for an example usage).


https://reviews.llvm.org/D22507



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to