https://github.com/Endilll commented:
LGTM > There is also TokenKind: this one does not currently inherit from > BaseEnumeration and is defined somewhat differently, having all its variants > and their IDs as a dictionary in enumerations.py. This seems quite arbitrary > to me, is there any reason it is done this way? Otherwise I would also move > this to cindex.py as another subclass of BaseEnumeration I agree that this seems arbitrary. You think you can proceed with refactoring `TokenKind`. https://github.com/llvm/llvm-project/pull/95608 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
