================
@@ -2986,6 +2989,9 @@ void 
MicrosoftCXXNameMangler::mangleCallingConvention(CallingConv CC) {
     case CC_Swift: Out << 'S'; break;
----------------
rnk wrote:

The default case here should be a proper compiler error, not an unreachable, 
since there's no good way to prevent arbitrary calling conventions from 
reaching the mangler.

If you search this file, you can find examples of "cannot yet mangle". Please 
copy that error handling pattern and use it in the default case for this switch 
to improve handling of cases like this in the future.

https://github.com/llvm/llvm-project/pull/96487
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to