weimingz added a comment.
The code looks OK except for the formatting. Since the logic is almost the
same as floattixf / floatuntixf except that some constants are different, I'm
wondering if it makes sense to reuse the existing code? For example, make
existing code as floattixf_impl.inc
================
Comment at: lib/builtins/floattitf.c:32
+COMPILER_RT_ABI fp_t
+__floattitf(ti_int a)
+{
----------------
Please put "{" on the same line like __floattitf(ti_int a) {
Same for other occurrences below
https://reviews.llvm.org/D27898
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
