rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land.
This side looks good. ================ Comment at: lib/CodeGen/CGDebugInfo.cpp:325 +llvm::DIFile::ChecksumKind +CGDebugInfo::getChecksum(FileID FID, SmallString<32> &Checksum) const { + Checksum.clear(); ---------------- This is uncached. Maybe call it computeChecksum to indicate that it is expensive? https://reviews.llvm.org/D27641 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits