llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT--> @llvm/pr-subscribers-clang-codegen Author: Kazu Hirata (kazutakahirata) <details> <summary>Changes</summary> This patch is based on clang-tidy's modernize-make-unique but limited to those cases where type names are mentioned twice like std::unique_ptr<Type>(new Type()), which is a bit mouthful. --- Full diff: https://github.com/llvm/llvm-project/pull/97176.diff 2 Files Affected: - (modified) clang/lib/CodeGen/CGCoroutine.cpp (+1-1) - (modified) clang/lib/Interpreter/CodeCompletion.cpp (+1-2) ``````````diff diff --git a/clang/lib/CodeGen/CGCoroutine.cpp b/clang/lib/CodeGen/CGCoroutine.cpp index b4c724422c14a..a8a70186c2c5a 100644 --- a/clang/lib/CodeGen/CGCoroutine.cpp +++ b/clang/lib/CodeGen/CGCoroutine.cpp @@ -103,7 +103,7 @@ static void createCoroData(CodeGenFunction &CGF, return; } - CurCoro.Data = std::unique_ptr<CGCoroData>(new CGCoroData); + CurCoro.Data = std::make_unique<CGCoroData>(); CurCoro.Data->CoroId = CoroId; CurCoro.Data->CoroIdExpr = CoroIdExpr; } diff --git a/clang/lib/Interpreter/CodeCompletion.cpp b/clang/lib/Interpreter/CodeCompletion.cpp index 25183ae9eeb99..791426807cb91 100644 --- a/clang/lib/Interpreter/CodeCompletion.cpp +++ b/clang/lib/Interpreter/CodeCompletion.cpp @@ -368,8 +368,7 @@ void ReplCodeCompleter::codeComplete(CompilerInstance *InterpCI, llvm::SmallVector<const llvm::MemoryBuffer *, 1> tb = {}; InterpCI->getFrontendOpts().Inputs[0] = FrontendInputFile( CodeCompletionFileName, Language::CXX, InputKind::Source); - auto Act = std::unique_ptr<IncrementalSyntaxOnlyAction>( - new IncrementalSyntaxOnlyAction(ParentCI)); + auto Act = std::make_unique<IncrementalSyntaxOnlyAction>(ParentCI); std::unique_ptr<llvm::MemoryBuffer> MB = llvm::MemoryBuffer::getMemBufferCopy(Content, CodeCompletionFileName); llvm::SmallVector<ASTUnit::RemappedFile, 4> RemappedFiles; `````````` </details> https://github.com/llvm/llvm-project/pull/97176 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits