================ @@ -0,0 +1,516 @@ +//===--- rtsan_test_interceptors.cpp - Realtime Sanitizer -------*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception +// +//===----------------------------------------------------------------------===// ---------------- vitalybuka wrote:
> Should we have a lit test for every intereceptor? I don't have strong preference. For other sanitizer default interceptor behavior is to crash, so we usually create a test per interceptor. > The reason we did it in gtest unit tests is that adding a new interceptor's > test is a few lines, as opposed to a brand new file with the lit boilerplate. > This makes it easy to make sure that every interceptor does what we think it > does. We worried about the "cost" of the new file for every interceptor. In > our demo branch, as we have it laid out, the lit tests test on the full > end-to-end system level, while these tests actually hit every interceptor. Yes, boilerplate of LIT is not nice. So there is a trade off. I guess you can wait and see. https://github.com/llvm/llvm-project/pull/92460 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
