alexfh added a comment. In https://reviews.llvm.org/D21298#632265, @alexfh wrote:
> In https://reviews.llvm.org/D21298#632235, @aaron.ballman wrote: > > > In https://reviews.llvm.org/D21298#632154, @xazax.hun wrote: > > > > > Small ping, is this ready to be committed? > > > > > > If @alexfh doesn't sign off by tomorrow, I think it's fine to commit. We > > can deal with any last minute comments post-commit. > > > Yup, that's totally fine, especially when there was a thorough pre-commit > code review. Clarification: it's totally fine to submit without waiting for me longer than a grace period of a day or so, once all comments are addressed and other reviewers have LGTM'd the patch. However, here specifically I have a few more comments ;) https://reviews.llvm.org/D21298 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
