github-actions[bot] wrote: <!--LLVM CODE FORMAT COMMENT: {clang-format}-->
:warning: C/C++ code formatter, clang-format found issues in your code. :warning: <details> <summary> You can test this locally with the following command: </summary> ``````````bash git-clang-format --diff 8bdc3d9ebb19e8c455c77241ef52ea74be6acfed 1dd1cbb1b13d0b038fa511620af993238a5bb260 --extensions cpp,c,h -- clang/test/CodeGen/overflow-idiom-exclusion-fp.c clang/test/CodeGen/overflow-idiom-exclusion.c clang/include/clang/AST/Expr.h clang/include/clang/Driver/SanitizerArgs.h clang/lib/AST/Expr.cpp clang/lib/CodeGen/CGExprScalar.cpp clang/lib/Driver/SanitizerArgs.cpp clang/lib/Driver/ToolChains/Clang.cpp `````````` </details> <details> <summary> View the diff from clang-format here. </summary> ``````````diff diff --git a/clang/include/clang/AST/Expr.h b/clang/include/clang/AST/Expr.h index c329ee061c..e8dc22c51a 100644 --- a/clang/include/clang/AST/Expr.h +++ b/clang/include/clang/AST/Expr.h @@ -4019,9 +4019,7 @@ public: return isShiftAssignOp(getOpcode()); } - bool ignoreOverflowSanitizers() const { - return isOverflowIdiom; - } + bool ignoreOverflowSanitizers() const { return isOverflowIdiom; } /// Return true if a binary operator using the specified opcode and operands /// would match the 'p = (i8*)nullptr + n' idiom for casting a pointer-sized diff --git a/clang/lib/AST/Expr.cpp b/clang/lib/AST/Expr.cpp index c07560c921..d963d47344 100644 --- a/clang/lib/AST/Expr.cpp +++ b/clang/lib/AST/Expr.cpp @@ -4764,7 +4764,8 @@ namespace { /// sanitization disabled. Check for the common pattern `if (a + b < a)` and /// return the resulting BinaryOperator responsible for the addition so we can /// elide overflow checks during codegen. -static std::optional<BinaryOperator *> getOverflowIdiomBinOp(const BinaryOperator *E) { +static std::optional<BinaryOperator *> +getOverflowIdiomBinOp(const BinaryOperator *E) { Expr *Addition, *ComparedTo; if (E->getOpcode() == BO_LT) { Addition = E->getLHS(); @@ -4819,7 +4820,7 @@ BinaryOperator::BinaryOperator(const ASTContext &Ctx, Expr *lhs, Expr *rhs, SubExprs[LHS] = lhs; SubExprs[RHS] = rhs; if (!Ctx.getLangOpts().SanitizeOverflowIdioms) { - std::optional<BinaryOperator*> Result = getOverflowIdiomBinOp(this); + std::optional<BinaryOperator *> Result = getOverflowIdiomBinOp(this); if (Result.has_value()) Result.value()->isOverflowIdiom = true; } diff --git a/clang/lib/CodeGen/CGExprScalar.cpp b/clang/lib/CodeGen/CGExprScalar.cpp index be0307073f..43a3a333fa 100644 --- a/clang/lib/CodeGen/CGExprScalar.cpp +++ b/clang/lib/CodeGen/CGExprScalar.cpp @@ -24,8 +24,8 @@ #include "clang/AST/Attr.h" #include "clang/AST/DeclObjC.h" #include "clang/AST/Expr.h" -#include "clang/AST/RecordLayout.h" #include "clang/AST/ParentMapContext.h" +#include "clang/AST/RecordLayout.h" #include "clang/AST/StmtVisitor.h" #include "clang/Basic/CodeGenOptions.h" #include "clang/Basic/TargetInfo.h" `````````` </details> https://github.com/llvm/llvm-project/pull/100272 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits