compnerd added inline comments.
================
Comment at: src/cxa_new_delete.cpp:34
*/
-__attribute__((__weak__, __visibility__("default")))
+__attribute__((__weak__))
void *
----------------
EricWF wrote:
> Can we abstract this away to a `_LIBCXXABI_NEW_DELETE_VIS` macro?
Are `operator new` and `operator delete` the only functions that will ever need
weak linkage? I think that using a more generic macro would be nicer.
`_LIBCXXABI_WEAK_LINKAGE` perhaps?
https://reviews.llvm.org/D26949
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
