EricWF added a comment.
In https://reviews.llvm.org/D28725#646325, @smeenai wrote:
> Awesome. LGTM except that force-removing the `_DEBUG` define and then linking
> against the debug libraries might cause some wonkiness.
Ack. I'll update the patch to still force remove `_DEBUG` but then later re-add
it under the correct circumstances.
================
Comment at: CMakeLists.txt:394
# non-debug DLLs
remove_flags("/D_DEBUG" "/MTd" "/MDd" "/MT" "/Md" "/RTC1")
----------------
smeenai wrote:
> We should be able to remove this now, right?
I would still rather strip it and re-add it. Just incase it gets added by LLVM
or another parent project.
https://reviews.llvm.org/D28725
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
