aaron.ballman added inline comments.
================
Comment at: lib/Sema/SemaDeclAttr.cpp:5137
+ if (!checkAttributeNumArgs(S, Attr, 0)) {
+ Attr.setInvalid();
+ return;
----------------
No need to call `Attr.setInvalid()` here or below.
================
Comment at: test/CodeGen/avr/attributes/interrupt.c:3
+
+// CHECK: define void @foo() #0
+__attribute__((interrupt)) void foo(void) { }
----------------
dylanmckay wrote:
> aaron.ballman wrote:
> > As should this.
> It seems like this sort of test _does_ sit in `CodeGen` - see
> `test/CodeGen/{arm-interrupt-attr.c|mips-interrupt-attr.c}`.
>
You're correct, this test does belong here. I think I attached my comment to
the wrong thing (sorry about that).
https://reviews.llvm.org/D28451
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
