dberris accepted this revision. dberris added a comment. This revision is now accepted and ready to land.
Just a minor comment -- I suspect you're going to wait until the patch to LLVM lands? ================ Comment at: lib/Sema/SemaDeclAttr.cpp:4407 + + // It isn't a parameter index [0;n), it's a count [1;n] - hence the + 1. + D->addAttr(::new (S.Context) ---------------- What is "It" referring to here? The argument? https://reviews.llvm.org/D29704 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
