probinson added a comment. In https://reviews.llvm.org/D28404#675687, @chandlerc wrote:
> In https://reviews.llvm.org/D28404#675616, @mehdi_amini wrote: > > > We're still waiting for @rsmith to comment whether it'd be better to `have > > a LangOpts flag that basically means "pragma clang optimize off is always > > in effect."` and `Have Sema pretend the pragma is in effect at all times, > > at -O0`. > > > FWIW, I have no real opinion about this side of it, I see it more as a detail > of how Clang wants to implement this kind of thing. That was my suggestion as it seemed like this patch is essentially replicating the attribute-conflict detection logic that's in place for attributes specified in the source. And we do like to say DRY. But I won't insist; the patch can proceed as far as I'm concerned. https://reviews.llvm.org/D28404 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
