pirama added inline comments.

================
Comment at: test/Driver/arch-specific-libdir-rpath.c:6
+// -rpath only gets added during native compilation
+// REQUIRES: native
+//
----------------
pirama wrote:
> I feel this test is fragile.  Any idea how to further restrict and require 
> that the default target triple has linux and one of i386, x86_64, arm, 
> aarch64?
> 
> I could create sub-dirs for all archs returned by Triple::getArchTypeName 
> (llvm/lib/Support/Triple.cpp) but it seems overkill.
I've restricted the test to just x86_64-linux.


https://reviews.llvm.org/D30015



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to