[PATCH] D30210: [include-fixer] Add usage count to find-all-symbols.

[Sam McCall via Phabricator via cfe-commits]

sammccall added a comment.

Thanks for the review, still learning the style :)



================
Comment at: include-fixer/find-all-symbols/FindAllSymbols.cpp:250
+  } else {
+    assert(!"Must match a NamedDecl!");
+  }
----------------
hokein wrote:
> Is the preceding `!` intended?
This does the right thing (!"string" is always false) but generates a warning.
Changed to assert(false && ...)


https://reviews.llvm.org/D30210



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits