llvmbot wrote:

<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-clang

Author: Anutosh Bhat (anutosh491)

<details>
<summary>Changes</summary>

While running clang-repl in the browser, we would be interested in this cc1 
command 

`
"" -cc1 -triple wasm32-unknown-emscripten -emit-obj -disable-free 
-clear-ast-before-backend -disable-llvm-verifier -discard-value-names 
-main-file-name "&lt;&lt;&lt; inputs &gt;&gt;&gt;" -mrelocation-model static 
-mframe-pointer=none -ffp-contract=on -fno-rounding-math -mconstructor-aliases 
-target-cpu generic -debugger-tuning=gdb -fdebug-compilation-dir=/ -v 
-fcoverage-compilation-dir=/ -resource-dir /lib/clang/19 -internal-isystem 
/include/wasm32-emscripten/c++/v1 -internal-isystem /include/c++/v1 
-internal-isystem /lib/clang/19/include -internal-isystem 
/include/wasm32-emscripten -internal-isystem /include -std=c++17 
-fdeprecated-macro -ferror-limit 19 -fvisibility=default -fgnuc-version=4.2.1 
-fskip-odr-check-in-gmf -fcxx-exceptions -fexceptions -fincremental-extensions 
-o "&lt;&lt;&lt; inputs &gt;&gt;&gt;.o" -x c++ "&lt;&lt;&lt; inputs 
&gt;&gt;&gt;"
`

As can be seen shared is anyway overwritten by static which is also what would 
be provided by default. Hence we can get rid of the shared flag here.

---
Full diff: https://github.com/llvm/llvm-project/pull/118107.diff


1 Files Affected:

- (modified) clang/lib/Interpreter/Interpreter.cpp (-1) 


``````````diff
diff --git a/clang/lib/Interpreter/Interpreter.cpp 
b/clang/lib/Interpreter/Interpreter.cpp
index 887b494ff98f19..fa4c1439c92612 100644
--- a/clang/lib/Interpreter/Interpreter.cpp
+++ b/clang/lib/Interpreter/Interpreter.cpp
@@ -200,7 +200,6 @@ IncrementalCompilerBuilder::CreateCpp() {
 #ifdef __EMSCRIPTEN__
   Argv.push_back("-target");
   Argv.push_back("wasm32-unknown-emscripten");
-  Argv.push_back("-shared");
   Argv.push_back("-fvisibility=default");
 #endif
   Argv.insert(Argv.end(), UserArgs.begin(), UserArgs.end());

``````````

</details>


https://github.com/llvm/llvm-project/pull/118107
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to