rmaprath marked an inline comment as done.
rmaprath added inline comments.
================
Comment at: buildbot/osuosl/master/config/builders.py:1196
+ lit_extra_opts={'link_flags': '"-lc++abi -lc -lm -lpthread -ldl
-L/opt/llvm/lib/clang/3.9.0/lib/linux -lclang_rt.builtins-armhf"'},
+ cmake_extra_opts={'LIBCXX_ENABLE_EXCEPTIONS': 'OFF',
+ 'LIBCXXABI_ENABLE_EXCEPTIONS': 'OFF',
----------------
rengolin wrote:
> rmaprath wrote:
> > rengolin wrote:
> > > Why remove the unwinder?
> > The unwinder should not be required for the no-exceptions library testing,
> > as these libraries do not throw/catch any exceptions.
> >
> > / Asiri
> But the requirement is not only to test it, but to make them work. We had
> trouble making the bot pass without the unwinder, due to dependencies.
>
> Regardless, this is a *different* change and should be made later, with
> proper research. For now, just add the new flag, please.
If you have a time (heh!), please do try out without the unwinder and see if it
still works fine. I'll be quite interested if it doesn't.
Downstream we have even more stricter tests to make sure there are no exception
tables in the final binaries, but this require special linker options. It would
be good to make sure that we can at least do without the unwinder upstream :)
https://reviews.llvm.org/D30290
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
