================
@@ -2021,28 +2021,10 @@ llvm::DISubroutineType
*CGDebugInfo::getOrCreateInstanceMethodType(
// ThisPtr may be null if the member function has an explicit 'this'
// parameter.
if (!ThisPtr.isNull()) {
- const CXXRecordDecl *RD = ThisPtr->getPointeeCXXRecordDecl();
- if (isa<ClassTemplateSpecializationDecl>(RD)) {
----------------
dwblaikie wrote:
huh, interesting archaeology... Wish we knew which test in particular it was.
This change might've been before I changed one of the old/core (before vtables,
template specializations, and ctor homing) -flimit-debug-info thing which was
more ad-hoc, to be powered by class "required to be complete" events.
So, yeah, I could totally believe whatever this code did may've been subsumed
by other work/generalizations/etc since then.
but, yeah, if we're removing it, best to do it separately in an NFC change & if
someone's feeling like doing due diligence, perhaps building clang with/without
this change (on linux, or otherwise with -flimit-debug-info enabled) and
checking the binary output is identical?
https://github.com/llvm/llvm-project/pull/119041
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
