EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM minus inline comments.
@smeenai confirmed that this patch doesn't change the ABI list for
`libc++abi.dylib` using `sym_check.py`.
================
Comment at: src/abort_message.h:19
-__attribute__((visibility("hidden"), noreturn))
- void abort_message(const char* format, ...)
- __attribute__((format(printf, 1, 2)));
-
+_LIBCXXABI_HIDDEN __attribute__((noreturn)) void
+abort_message(const char *format, ...) __attribute__((format(printf, 1, 2)));
----------------
`LIBCXXABI_NORETURN`?
https://reviews.llvm.org/D26949
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
