carlocab wrote:

After excluding the `-darwin*` spelling from using `xcselect`, most of the 
failures go away, but one remains. I'll investigate it tomorrow.

I've left it as `XFAIL` for now, since it seems to be the least bad option 
(compared to `CLANG_NO_XCSELECT` or `UNSUPPORTED`), given:

> > I'm wondering if it's worth reviving the CLANG_NO_XCSELECT environment 
> > variable and then just setting them in these tests (and slowly getting rid 
> > of instances of CLANG_NO_XCSELECT as we find better fixes).
> 
> The downside here is that when investigating running each command, it might 
> be confusing that the error is not reproducing unless an env is set.
> 
> Alternative is just `UNSUPPORTED:` but that will reduce the coverage when 
> XCSELECT is configured.

https://github.com/llvm/llvm-project/pull/119670
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to