spall wrote:

> This looks correct, but how much work is it to update all of these tests to 
> have fast math enabled rather than explicitly disabling it? I worry that (1) 
> folks looking at these tests in the future will think that disabling fast 
> math is a meaningful part of the test and (2) people will crib these run 
> lines and add more tests that build with non-default flags for no particular 
> reason

It's definitely more difficult, because I was able to  add -fno-fast-math with 
a quick search and replace.  Of course I'll do it the way you suggest if you 
think that is better.

https://github.com/llvm/llvm-project/pull/119820
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to