djasper added a comment.

Please don't add this as is. I don't usually run the file-based tests in my 
development workflow and suspect that I might be breaking this a lot.

If you want something like this, please add it as unittest(s) in 
unittests/Format/... (either in a new file or in an existing one)

Reasons:

- They are much faster to run.
- If a specific thing breaks, I find that much easier to narrow down and 
understand.

What problem is this addressing, though? Have we frequently changed formatting 
in a way that has negatively impacted Mozilla code?


https://reviews.llvm.org/D30111



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to