gerazo marked an inline comment as done.
gerazo added inline comments.
================
Comment at: lib/AST/ASTImporter.cpp:5221
IdentifierInfo *ToII = Importer.Import(S->getOutputIdentifier(I));
- if (!ToII)
- return nullptr;
+ // ToII is nullptr when no symbolic name is given for output operand
+ // see ParseStmtAsm::ParseAsmOperandsOpt
----------------
a.sidorin wrote:
> In such cases, we should check that FromIdentifier is `nullptr` too (to
> detect cases where the result is `nullptr` due to import error). The check
> will be still present but will look like:
> ```
> if (!ToII && S->getOutputIdentifier())
> return nullptr;
> ```
> The same below.
Thank you Aleksei, done.
https://reviews.llvm.org/D30831
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
