Anastasia added inline comments.

================
Comment at: test/SemaOpenCL/overload-scalar-widening.cl:4
+
+typedef short short4 __attribute__((ext_vector_type(4)));
+
----------------
I am thinking could this be a CodeGen test instead and we could check that the 
right overload is selected based on mangled name?

I think in this case it would be good to unify with 
test/SemaOpenCL/overload_addrspace_resolution.cl which has similar purpose. 
Also I think CodeGenOpenCL would be a better place for it. :) 


https://reviews.llvm.org/D30816



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to