bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land.
LGTM ================ Comment at: lib/Frontend/CompilerInvocation.cpp:1434 + + // Canonicalize -fmodules-cache-path before storing it. + SmallString<128> P(Args.getLastArgValue(OPT_fmodules_cache_path)); ---------------- I would suggest using `FileManager::makeAbsolutePath`, but at this point looks like we haven't set up a FileManager yet. https://reviews.llvm.org/D30915 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits