androm3da wrote:

> > > I also so comments on the python script, but as I mentioned there, the 
> > > script is not code I'm suggesting to check in or maintain, merely 
> > > documenting for completeness. It was never written to be remotely 
> > > readable or clean, just to produce a verifiably equivalent TableGen file.
> > 
> > 
> > Sure - that's fine, I guess I am mostly skimming it for Ikhlas' sake in 
> > case she wants to run something similar downstream.
> > LGTM.
> 
> Should I still wait for @iajbar to review before merging? Just wasn't super 
> clear from this comment.

Yeah that wasn't clear, sorry.  "LGTM but @iajbar  should approve"

Ikhlas - you should note that since Chandler claims that the actual content is 
preserved, that likely this should function equivalently to the baseline.  But 
this is a good opportunity to ask questions about the transformation so that 
you can reproduce it downstream.

https://github.com/llvm/llvm-project/pull/123460
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to