GeorgeKA wrote: Hi @Maetveis . This is ready for review.
There are a few things that I came across while making the script that I should highlight : 1) clang -cc1 test directory [test/Driver/lit.local.cfg](https://github.com/llvm/llvm-project/blob/e10d551aa482ee185a80216b2670a2947a8bdeb0/clang/test/Driver/lit.local.cfg#L27) says, '_("%clang_cc1", """*** Do not use 'clang -cc1' in Driver tests. ***""")_', yet I see various tests in that directory that do so, like [linker-wrapper.c](https://github.com/llvm/llvm-project/blob/e10d551aa482ee185a80216b2670a2947a8bdeb0/clang/test/Driver/linker-wrapper.c#L10). If there's no opposition, I'll leave the cc1 tests in the main Lit test file, Driver/unsupported_in_drivermode.c. 2) flang vs flang -fc1 As per [clang/test/Driver/flang/flang.f90](https://github.com/llvm/llvm-project/blob/e10d551aa482ee185a80216b2670a2947a8bdeb0/clang/test/Driver/flang/flang.f90#L1), "flang -fc1 is invoked when in --driver-mode=flang", so I disabled the plain flang tests since there's no distinction. 3) Testing on Windows I disabled the tests on Windows given the following recursion error that occurs on Windows regression machines. (It has some odd formatting. Pasting in a text editor makes viewing it easier.) ``` ^[_bk;t=1737572755765^GPASS: Clang :: Driver/fsanitize-memory-param-retval.c (11017 of 21306)^M ^[_bk;t=1737572756104^G******************** TEST 'Clang :: Driver/flang/unsupported_in_flang.f90' FAILED ********************^M ^[_bk;t=1737572756104^G******************** TEST 'Clang :: Driver/flang/unsupported_in_flang.f90' FAILED ********************^M ^[_bk;t=1737572756104^GTraceback (most recent call last):^M ^[_bk;t=1737572756104^GTraceback (most recent call last):^M ^[_bk;t=1737572756104^GTraceback (most recent call last):^M ^[_bk;t=1737572756104^G File "C:\ws\src\llvm\utils\lit\lit\formats\shtest.py", line 29, in execute^M ^[_bk;t=1737572756104^G return lit.TestRunner.executeShTest(^M ^[_bk;t=1737572756104^G File "C:\ws\src\llvm\utils\lit\lit\TestRunner.py", line 2326, in executeShTest^M ^[_bk;t=1737572756104^G File "C:\ws\src\llvm\utils\lit\lit\TestRunner.py", line 2326, in executeShTest^M ^[_bk;t=1737572756104^G File "C:\ws\src\llvm\utils\lit\lit\TestRunner.py", line 2326, in executeShTest^M ^[_bk;t=1737572756104^G File "C:\ws\src\llvm\utils\lit\lit\TestRunner.py", line 2326, in executeShTest^M ^[_bk;t=1737572756104^G File "C:\ws\src\llvm\utils\lit\lit\TestRunner.py", line 2326, in executeShTest^M ^[_bk;t=1737572756104^G res = executeScriptInternal(^M ^[_bk;t=1737572756104^G File "C:\ws\src\llvm\utils\lit\lit\TestRunner.py", line 1110, in executeScriptInternal^M ^[_bk;t=1737572756104^G exitCode, timeoutInfo = executeShCmd(^M ^[_bk;t=1737572756104^G exitCode, timeoutInfo = executeShCmd(^M ^[_bk;t=1737572756104^G exitCode, timeoutInfo = executeShCmd(^M ^[_bk;t=1737572756104^G exitCode, timeoutInfo = executeShCmd(^M ^[_bk;t=1737572756104^G exitCode, timeoutInfo = executeShCmd(^M ^[_bk;t=1737572756104^G exitCode, timeoutInfo = executeShCmd(^M ^[_bk;t=1737572756104^G exitCode, timeoutInfo = executeShCmd(^M ^[_bk;t=1737572756104^G exitCode, timeoutInfo = executeShCmd(^M ^[_bk;t=1737572756104^G res = _executeShCmd(cmd.lhs, shenv, results, timeoutHelper)^M ^[_bk;t=1737572756104^G res = _executeShCmd(cmd.lhs, shenv, results, timeoutHelper)^M ^[_bk;t=1737572756104^G res = _executeShCmd(cmd.lhs, shenv, results, timeoutHelper)^M ^[_bk;t=1737572756104^G if timeoutHelper.timeoutReached():^M ^[_bk;t=1737572756104^G if timeoutHelper.timeoutReached():^M ``` https://github.com/llvm/llvm-project/pull/120900 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits