[PATCH] D30806: [nonnull] Teach Clang to attach the nonnull LLVM attribute to declarations and calls instead of just definitions, and then teach it to not attach such attributes even if the source code contains them.

Chandler Carruth via Phabricator via cfe-commits Thu, 16 Mar 2017 19:10:15 -0700

chandlerc added inline comments.


================
Comment at: include/clang/AST/ASTContext.h:1868
+                          bool *OverrideNonnullReturn = nullptr,
+                          unsigned *OverrideNonnullArgs = nullptr,
                           unsigned *IntegerConstantArgs = nullptr) const;
----------------
hfinkel wrote:
> It seems like you had to touch more code than necessary because you decided 
> to add these parameters before IntegerConstantArgs. Why don't you add them 
> afterward instead?
It seemed more natural.... But I'm happy to change the order. I'm not worreid 
about how much code I have to touch, I'd rather just get the options in the 
right place. What order would you suggest?


https://reviews.llvm.org/D30806



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D30806: [nonnull] Teach Clang to attach the nonnull LLVM attribute to declarations and calls instead of just definitions, and then teach it to *not* attach such attributes even if the source code contains them.

Reply via email to

[PATCH] D30806: [nonnull] Teach Clang to attach the nonnull LLVM attribute to declarations and calls instead of just definitions, and then teach it to not attach such attributes even if the source code contains them.