arphaman added inline comments.
================ Comment at: test/SemaObjC/attr-deprecated.m:124-128 +@interface A(Blah) // no warning +- (A*)getA; @end +@implementation A(Blah) // no warning ---------------- aaron.ballman wrote: > I would have assumed the use in the `@implementation` would have been enough > to trigger it, is that not the behavior we'd want? > > If not, can you extend the test to show that a use of the category triggers > the deprecation warning? I'm not sure. Typically an implementation of a category is located in a framework, so even if it's deprecated for the users of a framework, you wouldn't really want to get a warning about it when compiling that framework. That said there's is a non-default `-Wdeprecated-implementation` warning for class implementations, so I think it would make sense to use it for category implementations as well. I will add make sure that the warning is emitted when committing the patch. Repository: rL LLVM https://reviews.llvm.org/D31179 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
