CaseyCarter added a comment. I also have no problem with this change.
================ Comment at: test/support/poisoned_hash_helper.hpp:53 using LibraryHashTypes = TypeList< +#if !defined(TEST_WORKAROUND_C1XX_BROKEN_NULLPTR_CONVERSION_OPERATOR) #if TEST_STD_VER > 14 ---------------- I would merge these conditionals since they have identical extent. YMMV ;) ================ Comment at: test/support/test.workarounds/c1xx_broken_nullptr_conversion_operator.pass.cpp:16 + +#include <type_traits> + ---------------- IIRC, including "" headers before <> headers is not conventional for the test suite. https://reviews.llvm.org/D31260 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
