ioeric added inline comments.
================
Comment at: clang-rename/USRFinder.cpp:200
+ // Also find all USRs of nested declarations.
+ NestedNameSpecifierLocFinder Finder(const_cast<ASTContext &>(Context));
----------------
ioeric wrote:
> It is unclear to me what `nested declarations` are.
But what is the nested name? Is it the nested name specifier? Of what?
================
Comment at: clang-rename/USRLocFinder.cpp:195
+// Find all locations identified by the given USRs. Traverse the AST and find
+// every AST node whose USR is in the given USRs' set.
+class RenameLocFinder
----------------
I think this also does some renaming?
================
Comment at: clang-rename/USRLocFinder.cpp:217
+
+ // FIXME: For renaming declarations/definitions, prefix qualifiers should be
+ // filtered out.
----------------
Could you be more specific in this FIXME? I don't quite get it. Maybe an
example?
================
Comment at: clang-rename/USRLocFinder.cpp:359
+
+ // Returns a list of using declarations which are needed to update.
+ const std::vector<const UsingDecl *> &getUsingDecls() const {
----------------
I think these are using shadows only?
================
Comment at: clang-rename/USRLocFinder.h:36
+/// \return Replacement for renaming.
+std::vector<tooling::Replacement>
+createRenameReplacement(llvm::ArrayRef<std::string> USRs,
----------------
Why use `std::vector` instead of `tooling::Replacements`?
https://reviews.llvm.org/D31176
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
