george.burgess.iv added inline comments.
================ Comment at: test/Driver/debug-options.c:201 // +// GRECORD: "-dwarf-debug-flags" +// GRECORD: -### -c -grecord-gcc-switches ---------------- echristo wrote: > This seems a little light on the testing, would you mind adding some more > interesting lines here? (Also, -grecord-gcc-switches seems like an option we > might want to ignore for this?) re-pasting my comment, since it looks like it got dropped when we updated diffs: nit: since `RenderAsInput` args (`-Xlinker`, `-o`, ...) have cases where they're printed without their arg, can we check that at least `-o -` is printed sanely, as well? https://reviews.llvm.org/D30760 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
