aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

LGTM!



================
Comment at: lib/CodeGen/CGExprScalar.cpp:1712
   BinOp.Opcode = IsInc ? BO_Add : BO_Sub;
-  BinOp.FPContractable = false;
+  // FIXME: once UnaryOperator carries FPFeatures, copy it here.
   BinOp.E = E;
----------------
anemet wrote:
> aaron.ballman wrote:
> > Why not make UnaryOperator carry this information now, since it's needed?
> The trouble is that currently it's not needed.  I'd rather wait for a 
> fast-math flag that actually needs it so that we can write tests.
That seems sensible to me, thank you for the explanation.


https://reviews.llvm.org/D31166



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to