mgorny added inline comments.
================ Comment at: test/sanitizer_common/CMakeLists.txt:7 set(SUPPORTED_TOOLS) -if(CMAKE_SYSTEM_NAME MATCHES "Darwin|Linux|FreeBSD" AND NOT ANDROID) +if(CMAKE_SYSTEM_NAME MATCHES "Darwin|Linux|FreeBSD" AND NOT ANDROID AND + COMPILER_RT_HAS_ASAN) ---------------- jroelofs wrote: > Are the `CMAKE_SYSTEM_NAME_MATCHES` guards here necessary any more, now that > the checks are happening in config-ix.cmake? ASAN doesn't have any system guard in config-ix.cmake, and the other guards are different (narrower) than those in config-ix. I think those restrictions might be like that on purpose, so if I were to drop them, I'd rather do it in separate patch. @samsonov? https://reviews.llvm.org/D25157 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
