rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
================
Comment at: lib/CodeGen/CGCoroutine.cpp:225
+ void Emit(CodeGenFunction &CGF, Flags) override {
+ CGF.EmitStmt(Deallocate);
+ }
----------------
This will be called twice: once for a normal exit and once for exceptional
exit. In general, double emitting a `Stmt*` is not safe, since it might contain
a VarDecl or a LabelDecl, but this usage is safe because
`SubStmtBuilder::makeNewAndDeleteExpr()` builds two calls that can't declare
anything. That is *definitely* worth a comment. :)
https://reviews.llvm.org/D31460
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
