salari01 added inline comments.
================ Comment at: lib/Driver/ToolChains/Clang.cpp:1882 + TakeNextArg = true; } } else { ---------------- rogfer01 wrote: > I wonder if you should `break;` here if validation fails like the original > code did? The reason for removing it is that this way, all erroneous `-defsym` options specified can be listed during the same invocation. This provides a better user experience than tackling them one at a time, as with the original code. https://reviews.llvm.org/D31496 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits