Hahnfeld requested changes to this revision.
Hahnfeld added a comment.
This revision now requires changes to proceed.
Out of interest: This is a limition of the implementation, right? Because the
standard only says: `A throw executed inside a target region must cause
execution to resume within the same target region, and the same thread that
threw the exception must catch it.`
================
Comment at: test/OpenMP/target_parallel_no_exceptions.cpp:14
+ {
+ a = inc(a);
+ }
----------------
Please make the test be valid OpenMP: `inc` is not in `declare target` and it's
also a data race.
I think it's enough to only have a `target` construct in the test.
Repository:
rL LLVM
https://reviews.llvm.org/D29904
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
